[Fix?] Compilation of src/toolbar-factory broken after recent changes

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Fix?] Compilation of src/toolbar-factory broken after recent changes

Albrecht Dreß
Hi Peter:

your recent patch set (commit 8835d788ad2c8c4cf7000f4464f1e94c25304f2e) breaks the compilation of src/toolbar-factory.c on Ubuntu 16.04 LTS and Debian stable, as the GdkEvent structure does not have a time field.

A hopefully correct patch is attached.

Cheers,
Albrecht.
diff --git a/src/toolbar-factory.c b/src/toolbar-factory.c
index ed68cf1..8a824d4 100644
--- a/src/toolbar-factory.c
+++ b/src/toolbar-factory.c
@@ -813,11 +813,7 @@ tm_popup_context_menu_cb(GtkWidget    * toolbar,
                                  NULL);
     }
 #else                           /*GTK_CHECK_VERSION(3, 22, 0) */
-    if (event) {
-        event_time = event->time;
-    } else {
-        event_time = gtk_get_current_event_time();
-    }
+    event_time = gtk_get_current_event_time();
 
     if (button >= 0)
         gtk_menu_popup(GTK_MENU(menu), NULL, NULL, NULL, NULL, button,

_______________________________________________
balsa-list mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/balsa-list

attachment0 (484 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Fix?] Compilation of src/toolbar-factory broken after recent changes

Peter Bloomfield
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Albrecht,

On 06/16/2017 10:33:33 AM Fri, Albrecht Dreß wrote:
> Hi Peter:
>
> your recent patch set (commit 8835d788ad2c8c4cf7000f4464f1e94c25304f2e) breaks the compilation of src/toolbar-factory.c on Ubuntu 16.04 LTS and Debian stable, as the GdkEvent structure does not have a time field.

Oops--thanks for testing the build!

> A hopefully correct patch is attached.

Pushed to master.

Best,

Peter
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEARECAAYFAllD72EACgkQH1/UtbkqdPUseACgkCuEJ0VolqRc8/kNWixtx0ug
5rAAn1vPyGsaGD3JOBitzBQGElHOaTbW
=Y70I
-----END PGP SIGNATURE-----
_______________________________________________
balsa-list mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/balsa-list
Loading...