Freeze exception request

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Freeze exception request

Gustavo Noronha Silva-5
Hey,

A feature that is requested a lot is remembering whether notifications
are allowed for a site. We were stuck waiting for UI design, so we
decided to land the feature with no UI changes for now. We would like to
merge it to 3.22.

Unfortunately, even though it does not change UI elements, it does add a
string, since the change contains a new schema. That will only appear on
dconf-editor, so we believe it won't be too much of a problem.

The change:

https://git.gnome.org/browse/epiphany/commit/?id=6b1344e3404c0d0ac49aa10d32914360f5052ad2

Let me know if you have any questions.

Cheers,

Gustavo Noronha
_______________________________________________
epiphany-list mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/epiphany-list
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Freeze exception request

Piotr Drąg
2016-09-28 16:04 GMT+02:00 Gustavo Noronha Silva <[hidden email]>:

> A feature that is requested a lot is remembering whether notifications
> are allowed for a site. We were stuck waiting for UI design, so we
> decided to land the feature with no UI changes for now. We would like to
> merge it to 3.22.
>
> Unfortunately, even though it does not change UI elements, it does add a
> string, since the change contains a new schema. That will only appear on
> dconf-editor, so we believe it won't be too much of a problem.
>
> The change:
>
> https://git.gnome.org/browse/epiphany/commit/?id=6b1344e3404c0d0ac49aa10d32914360f5052ad2
>
> Let me know if you have any questions.
>

I don't see any new strings in the patch. Could you please point to it?

Best regards,

--
Piotr Drąg
https://piotrdrag.fedorapeople.org
_______________________________________________
epiphany-list mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/epiphany-list
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Freeze exception request

Gustavo Noronha Silva-5
Hey,

On Wed, Sep 28, 2016, at 01:19 PM, Piotr Drąg wrote:
> > The change:
> >
> > https://git.gnome.org/browse/epiphany/commit/?id=6b1344e3404c0d0ac49aa10d32914360f5052ad2
> >
> > Let me know if you have any questions.
> >
>
> I don't see any new strings in the patch. Could you please point to it?

The strings are in the gsettings schema, they will only be visible in
dconf-editor:

diff --git a/data/org.gnome.epiphany.host.gschema.xml
b/data/org.gnome.epiphany.host.gschema.xml
new file mode 100644
index 0000000..f70c7b7
--- /dev/null
+++ b/data/org.gnome.epiphany.host.gschema.xml
@@ -0,0 +1,13 @@
+<schemalist>
+  <enum id="org.gnome.Epiphany.host.permissions">
+    <value nick="undecided" value="-1"/>
+    <value nick="deny" value="0"/>
+    <value nick="allow" value="1"/>
+  </enum>
+
+  <schema id="org.gnome.Epiphany.host" gettext-domain="">
+    <key name="notifications-permission"
enum="org.gnome.Epiphany.host.permissions">
+      <default>"undecided"</default>
+    </key>
+  </schema>
+</schemalist>

Cheers,

Gustavo Noronha
_______________________________________________
epiphany-list mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/epiphany-list
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Freeze exception request

Michael Catanzaro-2
On Thu, 2016-09-29 at 07:46 -0300, Gustavo Noronha Silva wrote:

> The strings are in the gsettings schema, they will only be visible in
> dconf-editor:
>
> diff --git a/data/org.gnome.epiphany.host.gschema.xml
> b/data/org.gnome.epiphany.host.gschema.xml
> new file mode 100644
> index 0000000..f70c7b7
> --- /dev/null
> +++ b/data/org.gnome.epiphany.host.gschema.xml
> @@ -0,0 +1,13 @@
> +<schemalist>
> +  <enum id="org.gnome.Epiphany.host.permissions">
> +    <value nick="undecided" value="-1"/>
> +    <value nick="deny" value="0"/>
> +    <value nick="allow" value="1"/>
> +  </enum>
> +
> +  <schema id="org.gnome.Epiphany.host" gettext-domain="">
> +    <key name="notifications-permission"
> enum="org.gnome.Epiphany.host.permissions">
> +      <default>"undecided"</default>
> +    </key>
> +  </schema>
> +</schemalist>

Gustavo, where are the descriptions of the new settings? :-)

So you have inadventantly not broken string freeze. This patch doesn't
require approval for gnome-3-22, then. But please, add descriptions for
the settings on master.

Michael
_______________________________________________
epiphany-list mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/epiphany-list
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Freeze exception request

Gustavo Noronha Silva-5
o/

On Thu, Sep 29, 2016, at 08:01 AM, Michael Catanzaro wrote:

> > +  <schema id="org.gnome.Epiphany.host" gettext-domain="">
> > +    <key name="notifications-permission"
> > enum="org.gnome.Epiphany.host.permissions">
> > +      <default>"undecided"</default>
> > +    </key>
> > +  </schema>
> > +</schemalist>
>
> Gustavo, where are the descriptions of the new settings? :-)
>
> So you have inadventantly not broken string freeze. This patch doesn't
> require approval for gnome-3-22, then. But please, add descriptions for
> the settings on master.

Erm… yes, I forgot to write the descriptions back when I wrote the patch
originally. But there are strings in this patch anyway, because of the
nicks:

+  <enum id="org.gnome.Epiphany.host.permissions">
+    <value nick="undecided" value="-1"/>
+    <value nick="deny" value="0"/>
+    <value nick="allow" value="1"/>
+  </enum>

Whether that requires a freeze exception I do not know =). Will add
descriptions to master.

Cheers,

Gustavo Noronha
_______________________________________________
epiphany-list mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/epiphany-list
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Freeze exception request

Piotr Drąg
In reply to this post by Gustavo Noronha Silva-5
2016-09-29 12:46 GMT+02:00 Gustavo Noronha Silva <[hidden email]>:

> The strings are in the gsettings schema, they will only be visible in
> dconf-editor:
>
> diff --git a/data/org.gnome.epiphany.host.gschema.xml
> b/data/org.gnome.epiphany.host.gschema.xml
> new file mode 100644
> index 0000000..f70c7b7
> --- /dev/null
> +++ b/data/org.gnome.epiphany.host.gschema.xml
> @@ -0,0 +1,13 @@
> +<schemalist>
> +  <enum id="org.gnome.Epiphany.host.permissions">
> +    <value nick="undecided" value="-1"/>
> +    <value nick="deny" value="0"/>
> +    <value nick="allow" value="1"/>
> +  </enum>
> +
> +  <schema id="org.gnome.Epiphany.host" gettext-domain="">
> +    <key name="notifications-permission"
> enum="org.gnome.Epiphany.host.permissions">
> +      <default>"undecided"</default>
> +    </key>
> +  </schema>
> +</schemalist>
>

There are no strings that would be extracted for translation here, as
far as I know.

Best regards,

--
Piotr Drąg
https://piotrdrag.fedorapeople.org
_______________________________________________
epiphany-list mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/epiphany-list
Loading...