[Patch] Assistant improvements

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Patch] Assistant improvements

Albrecht Dreß
Hi all,

I noticed that the assistant for configuring balsa contains minor flaws:
- if the mail address is guessed using /etc/mailname, it contains a trailing newline
- the assistant asks for POP3 or IMAP SSL only, not for TLS.

The attached patch fixes it:
- libbalsa/libbalsa.c: read /etc/mailname using glib, and remove everything starting with the 1st newline
- libinit_balsa/assistant_page_user.[ch]: replace the "SSL" checkbox by a combo asking for the requested security mode

Opinions?

Cheers,
Albrecht.
_______________________________________________
balsa-list mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/balsa-list

assistant.diff (6K) Download Attachment
attachment1 (484 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Patch] Assistant improvements

Peter Bloomfield
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Albrecht:

On 05/01/2017 09:27:25 AM Mon, Albrecht Dreß wrote:

> Hi all,
>
> I noticed that the assistant for configuring balsa contains minor flaws:
> - if the mail address is guessed using /etc/mailname, it contains a trailing newline
> - the assistant asks for POP3 or IMAP SSL only, not for TLS.
>
> The attached patch fixes it:
> - libbalsa/libbalsa.c: read /etc/mailname using glib, and remove everything starting with the 1st newline
> - libinit_balsa/assistant_page_user.[ch]: replace the "SSL" checkbox by a combo asking for the requested security mode
>
> Opinions?

Thanks for the patch!

Looks good to me--pushed to master.

Best,

Peter
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEARECAAYFAlkH1/EACgkQH1/UtbkqdPXuYgCgib3geqKUlhlfB69VXYadD++8
7NcAoIIPXOnNZ5vM1PCLy8u1EQMOWx6V
=nJp2
-----END PGP SIGNATURE-----
_______________________________________________
balsa-list mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/balsa-list
Loading...