Rename dialog: Patch for review

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Rename dialog: Patch for review

Kevin Connor Arpe
Hello,

There are a few small changes I would to make for the rename dialog.
Example: Fix tiny layout / margin issues and auto-size new name
GtkEntry (if current sheet name is very long).

I git-clone'd your repo and made changes (locally) to master branch.
I've tested the changes locally on my PC.  Now is the time to get some
feedback & review.

This is my first time to submit a patch for this project.  What is the
procedure?

Thanks,
Arpe
Hongkong
_______________________________________________
gnumeric-list mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/gnumeric-list
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Rename dialog: Patch for review

Morten Welinder-2
> What is the procedure?

Open bug at bugzilla.gnome.org and attach the patch.

M.


On Wed, Feb 1, 2017 at 12:27 PM, Kevin Connor Arpe <[hidden email]> wrote:

> Hello,
>
> There are a few small changes I would to make for the rename dialog.
> Example: Fix tiny layout / margin issues and auto-size new name
> GtkEntry (if current sheet name is very long).
>
> I git-clone'd your repo and made changes (locally) to master branch.
> I've tested the changes locally on my PC.  Now is the time to get some
> feedback & review.
>
> This is my first time to submit a patch for this project.  What is the
> procedure?
>
> Thanks,
> Arpe
> Hongkong
> _______________________________________________
> gnumeric-list mailing list
> [hidden email]
> https://mail.gnome.org/mailman/listinfo/gnumeric-list
_______________________________________________
gnumeric-list mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/gnumeric-list
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Rename dialog: Patch for review

Kevin Connor Arpe
Done: https://bugzilla.gnome.org/show_bug.cgi?id=778168

On Thu, Feb 2, 2017 at 1:32 AM, Morten Welinder <[hidden email]> wrote:

>> What is the procedure?
>
> Open bug at bugzilla.gnome.org and attach the patch.
>
> M.
>
>
> On Wed, Feb 1, 2017 at 12:27 PM, Kevin Connor Arpe <[hidden email]> wrote:
>> Hello,
>>
>> There are a few small changes I would to make for the rename dialog.
>> Example: Fix tiny layout / margin issues and auto-size new name
>> GtkEntry (if current sheet name is very long).
>>
>> I git-clone'd your repo and made changes (locally) to master branch.
>> I've tested the changes locally on my PC.  Now is the time to get some
>> feedback & review.
>>
>> This is my first time to submit a patch for this project.  What is the
>> procedure?
>>
>> Thanks,
>> Arpe
>> Hongkong
>> _______________________________________________
>> gnumeric-list mailing list
>> [hidden email]
>> https://mail.gnome.org/mailman/listinfo/gnumeric-list
_______________________________________________
gnumeric-list mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/gnumeric-list
Loading...