Roadmap review

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Roadmap review

Michael Catanzaro-2
Hi,

Reviewing our roadmap:

https://wiki.gnome.org/Apps/Web/Roadmap

We've made tremendous progress on feature development this cycle. Big
thanks to everyone who helped out there: Gabriel on Firefox Sync,
Iulian on the new bookmarks subsystem and major internal code
improvements, Daniel on HTTPS Everywhere, Jakub and Lapo on the new
Epiphany icon, Sergio on password form detection, Carlos the upcoming
personal data manager and for cleaning up when I've broken things, and
Cedric for the upcoming search engines dialog.

We still have some major regressions from Epiphany 3.22 [1][2][3]. I am
going to try to fix or mitigate them all before the 3.24 release, but I
have more on my to-do list than I'm realistically going to accomplish
in that time, so help would be very much welcome.

I've also added several tasks to the roadmap for 3.26. Please let me
know if you're interested in helping with any of those, especially the
unassigned ones.

Michael

[1] http://bugzilla.gnome.org/show_bug.cgi?id=772106
[2] http://bugzilla.gnome.org/show_bug.cgi?id=775145
[3] http://bugzilla.gnome.org/show_bug.cgi?id=775902
_______________________________________________
epiphany-list mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/epiphany-list
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Roadmap review

Adrian Perez de Castro
On Sat, 28 Jan 2017 13:32:03 -0600, Michael Catanzaro <[hidden email]> wrote:

> Reviewing our roadmap:
>
> https://wiki.gnome.org/Apps/Web/Roadmap
>
> We've made tremendous progress on feature development this cycle [...]

\o/

> [2] http://bugzilla.gnome.org/show_bug.cgi?id=775145

I ended up hacking up a quick benchmark [1] for JS-based syntax highlighters
for this, check the comments in the bug report :-)

Also, I wondering... Would it make sense to embed a GtkSourceView in an
Epiphany tab for this?

Cheers,


🎩 Adrián

[1] https://github.com/aperezdc/js-highlighters-shootout

_______________________________________________
epiphany-list mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/epiphany-list

attachment0 (201 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Roadmap review

Michael Catanzaro-2
On Mon, 2017-01-30 at 00:27 +0200, Adrian Perez de Castro wrote:
> Also, I wondering... Would it make sense to embed a GtkSourceView in
> an
> Epiphany tab for this?

Maybe. Can it be made non-editable?

GtkSourceView syntax highlighting works almost instantly, so that would
surely be preferable.

(Of course this bug has an easy fallback plan: just revert my half-
baked commits that brought back internal view source mode.)

Michael
_______________________________________________
epiphany-list mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/epiphany-list
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Roadmap review

Adrian Perez de Castro
On Sun, 29 Jan 2017 18:34:23 -0600, Michael Catanzaro <[hidden email]> wrote:
> On Mon, 2017-01-30 at 00:27 +0200, Adrian Perez de Castro wrote:
> > Also, I wondering... Would it make sense to embed a GtkSourceView in an
> > Epiphany tab for this?
>
> Maybe. Can it be made non-editable?
>
> GtkSourceView syntax highlighting works almost instantly, so that would
> surely be preferable.

Yes. The widget inherits from GtkTextView, which has an “editable” boolean
property:

  https://developer.gnome.org/gtk3/stable/GtkTextView.html#GtkTextView--editable

I took a quick peek at how “ephy-source://” is handled, and it could be that
including the “prism.js” script first and then the content, letting the script
detect which HTML elements need to be highlighted might have to do with the
sluggishness. I would do something like generating the following code:

  <html>
    <head>
          <link rel="stylesheet" type="text/css" href="ephy-resource:///prism.css">
        </head>
    <body>
          <pre id="highlight" style="display: none">${HTML_SOURCE}</pre>

          <!-- Do whatever is needed to turn of Prism's auto-detection
               of code block elements. -->
          <script type="text/javascript" src="ephy-resource://prism.js"></script>

          <script type="text/javascript">
          let el = document.getElementById('highlight');
                el.innerHTML = Prism.highlight(el.textContent, Prism.languages.html);
            el.style.hidden = "";  // Show the element.
          </script>
        </body>
  </html>

Note how the <pre> element is initially hidden, we do the syntax highlighting,
update the DOM, and then change the “display” style property *last*. This
completely avoids displaying elements while they are getting updated, which
saves relayout and redraws. My guess is that relayouts (which are expensive)
are the main culprit for highlighting being slow at the moment.

Cheers,


🎩 Adrián

P.S: I need to set that horrible thing called JHBuild to be able to try this
     kind of experiments myself with Epiphany's “master” branch. Often I get
     away with using the system-wide WebKitGTK+ but currently that's not
     working ;-)

_______________________________________________
epiphany-list mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/epiphany-list

attachment0 (201 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Roadmap review

Gianvito Cavasoli
In reply to this post by Michael Catanzaro-2
Il giorno sab, 28/01/2017 alle 13.32 -0600, Michael Catanzaro ha
scritto:

> Hi,
>
> Reviewing our roadmap:
>
> https://wiki.gnome.org/Apps/Web/Roadmap
>
> We've made tremendous progress on feature development this cycle. Big
> thanks to everyone who helped out there: Gabriel on Firefox Sync,
> Iulian on the new bookmarks subsystem and major internal code
> improvements, Daniel on HTTPS Everywhere, Jakub and Lapo on the new
> Epiphany icon, Sergio on password form detection, Carlos the upcoming
> personal data manager and for cleaning up when I've broken things,
> and
> Cedric for the upcoming search engines dialog.
>
> We still have some major regressions from Epiphany 3.22 [1][2][3]. I
> am
> going to try to fix or mitigate them all before the 3.24 release, but
> I
> have more on my to-do list than I'm realistically going to accomplish
> in that time, so help would be very much welcome.
>
> I've also added several tasks to the roadmap for 3.26. Please let me
> know if you're interested in helping with any of those, especially
> the
> unassigned ones.
>
> Michael
>
> [1] http://bugzilla.gnome.org/show_bug.cgi?id=772106
> [2] http://bugzilla.gnome.org/show_bug.cgi?id=775145
> [3] http://bugzilla.gnome.org/show_bug.cgi?id=775902
> _______________________________________________
> epiphany-list mailing list
> [hidden email]
> https://mail.gnome.org/mailman/listinfo/epiphany-list

Hi,
I can suggest to add a button in the headerbar (or menu, or keyboard
shortcut) to temporarily disable the Adblock feature? Some websites for
work (like uploaded.net) require disabling it.
Thanks.

--
Inviata con Evolution da GNOME
Profilo: https://it.gravatar.com/janvitus
«Lillo, la fine del mondo è vicina! Godiamocela!» 
                                                -- La bambina filosofica
_______________________________________________
epiphany-list mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/epiphany-list
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Roadmap review

Michael Catanzaro-2
On Sat, 2017-02-04 at 10:55 +0100, Gianvito Cavasoli wrote:
> Hi,
> I can suggest to add a button in the headerbar (or menu, or keyboard
> shortcut) to temporarily disable the Adblock feature? Some websites
> for
> work (like uploaded.net) require disabling it.
> Thanks.

Hi,

I think the header bar would be too intrusive for this, but we
certainly want the feature somewhere. I think we should actually expose
it in two different places:

 * Adblock preferences dialog, allowing users to subscribe to arbitrary
ABP filters and whitelist websites, something that's currently not
possible. This would be exposed somewhere in the preferences dialog.

 * Website permissions dialog. We are currently storing permissions
like notifications permission, geolocation permission,
webcam/microphone permission, etc. without any UI for forgetting
permissions. We should add UI for this, and permission to show ads or
run JavaScript could be treated as additional permissions. Maybe we
could use our existing security popover for this, like Chrome does.

Michael
_______________________________________________
epiphany-list mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/epiphany-list
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Roadmap review

cedlemo
In reply to this post by Michael Catanzaro-2
Michael,

I started to work on this
https://bugzilla.gnome.org/show_bug.cgi?id=671503, but since this bug is
not in the roadmap, maybe it is better that I start to work on one of
the remaining tasks for the v 3.26:

* Add reading list (queue mode)

* Restore in-browser view source mode (Stalled ?)

* Block dangerous websites using a safe browsing API

If you prefer that a more confirmed contributor works on them it is ok
no drama. FYI the implementation of a reading list is my favorite one.


Cedric


On 28/01/2017 20:32, Michael Catanzaro wrote:

> Hi,
>
> Reviewing our roadmap:
>
> https://wiki.gnome.org/Apps/Web/Roadmap
>
> We've made tremendous progress on feature development this cycle. Big
> thanks to everyone who helped out there: Gabriel on Firefox Sync,
> Iulian on the new bookmarks subsystem and major internal code
> improvements, Daniel on HTTPS Everywhere, Jakub and Lapo on the new
> Epiphany icon, Sergio on password form detection, Carlos the upcoming
> personal data manager and for cleaning up when I've broken things, and
> Cedric for the upcoming search engines dialog.
>
> We still have some major regressions from Epiphany 3.22 [1][2][3]. I am
> going to try to fix or mitigate them all before the 3.24 release, but I
> have more on my to-do list than I'm realistically going to accomplish
> in that time, so help would be very much welcome.
>
> I've also added several tasks to the roadmap for 3.26. Please let me
> know if you're interested in helping with any of those, especially the
> unassigned ones.
>
> Michael
>
> [1] http://bugzilla.gnome.org/show_bug.cgi?id=772106
> [2] http://bugzilla.gnome.org/show_bug.cgi?id=775145
> [3] http://bugzilla.gnome.org/show_bug.cgi?id=775902
> _______________________________________________
> epiphany-list mailing list
> [hidden email]
> https://mail.gnome.org/mailman/listinfo/epiphany-list


_______________________________________________
epiphany-list mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/epiphany-list
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Roadmap review

Michael Catanzaro-2
On Mon, 2017-02-27 at 12:34 +0100, cedlemo wrote:
> Michael,
>
> I started to work on this 
> https://bugzilla.gnome.org/show_bug.cgi?id=671503, but since this bug
> is 
> not in the roadmap, maybe it is better that I start to work on one
> of 
> the remaining tasks for the v 3.26:

You can work on whatever bugs you want. :P Thanks for looking into it.
frecency is an interesting idea. I'm not completely sure that the
result will be better than just sorting all bookmarks on top, but it's
certainly worth trying, and the final result will be easy to tweak by
just changing the parameters to the algorithm.

> * Add reading list (queue mode)
>
> * Restore in-browser view source mode (Stalled ?)
>
> * Block dangerous websites using a safe browsing API
>
> If you prefer that a more confirmed contributor works on them it is
> ok 
> no drama. FYI the implementation of a reading list is my favorite
> one.

Well based on your work on the search engines dialog (thanks!), I think
 you could put together a good reading list. The trouble with this is
that reading list is going to be used a lot more frequently than the
search engine dialog, so the design matters much more. Ideally we would
get mockups from the GNOME design team before starting on this. We
should also look at what Edge does, since it has a good reading list
implementation already. Do you have access to a Windows machine that
you can use to take screenshots of Edge? If not, I'll ask someone who
does to put together some screenshots of its reading list for us.

Thanks,

Michael
_______________________________________________
epiphany-list mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/epiphany-list
Loading...